Repository: phoenix Updated Branches: refs/heads/4.x-HBase-1.2 aae94a053 -> 10670d339
PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu) Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/10670d33 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/10670d33 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/10670d33 Branch: refs/heads/4.x-HBase-1.2 Commit: 10670d3399b92b7aec5f5c90dba6d046fe1561d4 Parents: aae94a0 Author: Rajeshbabu Chintaguntla <[email protected]> Authored: Wed May 24 15:05:29 2017 +0530 Committer: Rajeshbabu Chintaguntla <[email protected]> Committed: Wed May 24 15:05:29 2017 +0530 ---------------------------------------------------------------------- .../org/apache/phoenix/hbase/index/Indexer.java | 25 ++++---------------- 1 file changed, 5 insertions(+), 20 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/phoenix/blob/10670d33/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java index 15e53a3..ab8c434 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java @@ -96,6 +96,11 @@ import com.google.common.collect.Multimap; * nothing does. Currently, we do not support mixed-durability updates within a single batch. If you * want to have different durability levels, you only need to split the updates into two different * batches. + * <p> + * We don't need to implement {@link #postPut(ObserverContext, Put, WALEdit, Durability)} and + * {@link #postDelete(ObserverContext, Delete, WALEdit, Durability)} hooks because + * Phoenix always does batch mutations. + * <p> */ public class Indexer extends BaseRegionObserver { @@ -366,26 +371,6 @@ public class Indexer extends BaseRegionObserver { } @Override - public void postPut(ObserverContext<RegionCoprocessorEnvironment> e, Put put, WALEdit edit, - final Durability durability) throws IOException { - if (this.disabled) { - super.postPut(e, put, edit, durability); - return; - } - doPost(edit, put, durability); - } - - @Override - public void postDelete(ObserverContext<RegionCoprocessorEnvironment> e, Delete delete, - WALEdit edit, final Durability durability) throws IOException { - if (this.disabled) { - super.postDelete(e, delete, edit, durability); - return; - } - doPost(edit, delete, durability); - } - - @Override public void postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnvironment> c, MiniBatchOperationInProgress<Mutation> miniBatchOp, final boolean success) throws IOException { if (this.disabled) {
