Repository: phoenix
Updated Branches:
  refs/heads/4.x-HBase-1.2 c8cd24f59 -> 518a973cd


PHOENIX-3901 SpillableGroupByIT.testStatisticsAreNotWritten is failing


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/518a973c
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/518a973c
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/518a973c

Branch: refs/heads/4.x-HBase-1.2
Commit: 518a973cdbebf245b66e6ed8554714e3b3b63b39
Parents: c8cd24f
Author: Samarth Jain <sama...@apache.org>
Authored: Wed May 31 13:17:25 2017 -0700
Committer: Samarth Jain <sama...@apache.org>
Committed: Wed May 31 13:17:25 2017 -0700

----------------------------------------------------------------------
 .../apache/phoenix/schema/stats/StatisticsCollectorFactory.java  | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/518a973c/phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
----------------------------------------------------------------------
diff --git 
a/phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
 
b/phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
index 1fe329f..4e37e5c 100644
--- 
a/phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
+++ 
b/phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java
@@ -24,8 +24,6 @@ import static 
org.apache.phoenix.query.QueryServicesOptions.DEFAULT_STATS_COLLEC
 import java.io.IOException;
 
 import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
-import org.apache.phoenix.query.QueryServices;
-import org.apache.phoenix.query.QueryServicesOptions;
 
 /**
  * Provides new {@link StatisticsCollector} instances based on configuration 
settings for a
@@ -67,7 +65,7 @@ public class StatisticsCollectorFactory {
         return (env.getConfiguration().getBoolean(STATS_COLLECTION_ENABLED,
             DEFAULT_STATS_COLLECTION_ENABLED)
             // old config left here for backward compatibility. TODO: remove 
in the next major release
-            || env.getConfiguration().getBoolean(STATS_ENABLED_ATTRIB, true)
+            && env.getConfiguration().getBoolean(STATS_ENABLED_ATTRIB, true)
             )
             && StatisticsUtil.isStatsEnabled(env.getRegionInfo().getTable());
     }

Reply via email to