PHOENIX-4661 Handled deleted PTables in the MetadataCache Signed-off-by: Josh Elser <els...@apache.org> Signed-off-by: Sergey Soldatov <s...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/f1a3528c Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/f1a3528c Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/f1a3528c Branch: refs/heads/4.x-cdh5.11.2 Commit: f1a3528c0d2de870b7c232048bf8cf49f73b30ce Parents: 43b437a Author: Ankit Singhal <ankitsingha...@gmail.com> Authored: Tue Mar 20 18:54:05 2018 +0000 Committer: Pedro Boado <pbo...@apache.org> Committed: Thu Mar 22 09:15:50 2018 +0000 ---------------------------------------------------------------------- .../org/apache/phoenix/end2end/DropTableIT.java | 43 ++++++++++++++++++++ .../coprocessor/MetaDataEndpointImpl.java | 33 ++++++++------- .../coprocessor/PhoenixAccessController.java | 8 +--- 3 files changed, 64 insertions(+), 20 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/phoenix/blob/f1a3528c/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableIT.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableIT.java new file mode 100644 index 0000000..823605d --- /dev/null +++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableIT.java @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.junit.Assert.assertFalse; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.Statement; + +import org.junit.Test; + +public class DropTableIT extends ParallelStatsDisabledIT { + + @Test + public void testRepeatedDropTable() throws Exception { + final String tableName = generateUniqueName(); + final String url = getUrl(); + try (final Connection conn = DriverManager.getConnection(url); + final Statement stmt = conn.createStatement()) { + assertFalse(stmt.execute(String.format("CREATE TABLE %s(pk varchar not null primary key)", tableName))); + String dropTable = String.format("DROP TABLE IF EXISTS %s", tableName); + for (int i = 0; i < 5; i++) { + assertFalse(stmt.execute(dropTable)); + } + } + } +} http://git-wip-us.apache.org/repos/asf/phoenix/blob/f1a3528c/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java index 11e5e45..05ad959 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java @@ -1293,6 +1293,13 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso return function.getFunctionName() == null; } + private PTable getTable(RegionCoprocessorEnvironment env, byte[] key, ImmutableBytesPtr cacheKey, + long clientTimeStamp, long asOfTimeStamp, int clientVersion) throws IOException, SQLException { + PTable table = loadTable(env, key, cacheKey, clientTimeStamp, asOfTimeStamp, clientVersion); + if (table == null || isTableDeleted(table)) { return null; } + return table; + } + private PTable loadTable(RegionCoprocessorEnvironment env, byte[] key, ImmutableBytesPtr cacheKey, long clientTimeStamp, long asOfTimeStamp, int clientVersion) throws IOException, SQLException { @@ -1464,7 +1471,7 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso parentTableKey = SchemaUtil.getTableKey(ByteUtil.EMPTY_BYTE_ARRAY, parentPhysicalSchemaTableNames[1], parentPhysicalSchemaTableNames[2]); - PTable parentTable = loadTable(env, parentTableKey, new ImmutableBytesPtr(parentTableKey), + PTable parentTable = getTable(env, parentTableKey, new ImmutableBytesPtr(parentTableKey), clientTimeStamp, clientTimeStamp, clientVersion); if (parentTable == null) { builder.setReturnCode(MetaDataProtos.MutationCode.PARENT_TABLE_NOT_FOUND); @@ -1479,13 +1486,13 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso byte[] parentKey = SchemaUtil.getTableKey( parentSchemaTableNames[0] == null ? ByteUtil.EMPTY_BYTE_ARRAY : parentSchemaTableNames[0], parentSchemaTableNames[1], parentSchemaTableNames[2]); - parentTable = loadTable(env, parentKey, new ImmutableBytesPtr(parentKey), + parentTable = getTable(env, parentKey, new ImmutableBytesPtr(parentKey), clientTimeStamp, clientTimeStamp, clientVersion); if (parentTable == null) { // it could be a global view parentKey = SchemaUtil.getTableKey(ByteUtil.EMPTY_BYTE_ARRAY, parentSchemaTableNames[1], parentSchemaTableNames[2]); - parentTable = loadTable(env, parentKey, new ImmutableBytesPtr(parentKey), + parentTable = getTable(env, parentKey, new ImmutableBytesPtr(parentKey), clientTimeStamp, clientTimeStamp, clientVersion); } } @@ -1969,12 +1976,16 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso byte[] key = parentTableName == null ? lockKey : SchemaUtil.getTableKey(tenantIdBytes, schemaName, tableName); - - + Region region = env.getRegion(); + MetaDataMutationResult result = checkTableKeyInRegion(key, region); + if (result != null) { + done.run(MetaDataMutationResult.toProto(result)); + return; + } PTableType ptableType=PTableType.fromSerializedValue(tableType); long clientTimeStamp = MetaDataUtil.getClientTimeStamp(tableMetadata); byte[] cKey = SchemaUtil.getTableKey(tenantIdBytes, schemaName, tableName); - PTable loadedTable = loadTable(env, cKey, new ImmutableBytesPtr(cKey), clientTimeStamp, clientTimeStamp, + PTable loadedTable = getTable(env, cKey, new ImmutableBytesPtr(cKey), clientTimeStamp, clientTimeStamp, request.getClientVersion()); if (loadedTable == null) { builder.setReturnCode(MetaDataProtos.MutationCode.TABLE_NOT_FOUND); @@ -1986,13 +1997,6 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso SchemaUtil.getTableName(schemaName, tableName), TableName.valueOf(loadedTable.getPhysicalName().getBytes()), getParentPhysicalTableName(loadedTable), ptableType,loadedTable.getIndexes()); - - Region region = env.getRegion(); - MetaDataMutationResult result = checkTableKeyInRegion(key, region); - if (result != null) { - done.run(MetaDataMutationResult.toProto(result)); - return; - } List<RowLock> locks = Lists.newArrayList(); try { @@ -2000,6 +2004,7 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso if (key != lockKey) { acquireLock(region, key, locks); } + List<ImmutableBytesPtr> invalidateList = new ArrayList<ImmutableBytesPtr>(); result = doDropTable(key, tenantIdBytes, schemaName, tableName, parentTableName, @@ -3657,7 +3662,7 @@ public class MetaDataEndpointImpl extends MetaDataProtocol implements Coprocesso //check permission on data table long clientTimeStamp = MetaDataUtil.getClientTimeStamp(tableMetadata); - PTable loadedTable = loadTable(env, key, new ImmutableBytesPtr(key), clientTimeStamp, clientTimeStamp, + PTable loadedTable = getTable(env, key, new ImmutableBytesPtr(key), clientTimeStamp, clientTimeStamp, request.getClientVersion()); if (loadedTable == null) { builder.setReturnCode(MetaDataProtos.MutationCode.TABLE_NOT_FOUND); http://git-wip-us.apache.org/repos/asf/phoenix/blob/f1a3528c/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java index 7b9452d..62c158c 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java @@ -22,7 +22,6 @@ import java.net.InetAddress; import java.security.PrivilegedExceptionAction; import java.util.ArrayList; import java.util.Arrays; -import java.util.Collections; import java.util.HashSet; import java.util.List; import java.util.Set; @@ -67,7 +66,6 @@ import org.apache.phoenix.schema.PTable; import org.apache.phoenix.schema.PTableType; import org.apache.phoenix.util.MetaDataUtil; -import com.google.common.collect.Lists; import com.google.protobuf.RpcCallback; public class PhoenixAccessController extends BaseMetaDataEndpointObserver { @@ -102,10 +100,8 @@ public class PhoenixAccessController extends BaseMetaDataEndpointObserver { @Override public void preGetTable(ObserverContext<PhoenixMetaDataControllerEnvironment> ctx, String tenantId, String tableName, TableName physicalTableName) throws IOException { - for (BaseMasterAndRegionObserver observer : getAccessControllers()) { - observer.preGetTableDescriptors(new ObserverContext<MasterCoprocessorEnvironment>(), - Lists.newArrayList(physicalTableName), Collections.<HTableDescriptor> emptyList()); - } + if (!accessCheckEnabled) { return; } + requireAccess("GetTable" + tenantId, physicalTableName, Action.READ, Action.EXEC); } @Override