This is an automated email from the ASF dual-hosted git repository.

stoty pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix-queryserver.git


The following commit(s) were added to refs/heads/master by this push:
     new d10abfe  PHOENIX-7125 PQS tests fail when hbase-shaded-netty version 
used by minicluster does not match the version in phoenix-client (#157)
d10abfe is described below

commit d10abfe630e04ea2932d3f8e92db7f0531fd2fc6
Author: Istvan Toth <st...@apache.org>
AuthorDate: Thu Aug 15 10:17:43 2024 +0200

    PHOENIX-7125 PQS tests fail when hbase-shaded-netty version used by 
minicluster does not match the version in phoenix-client (#157)
    
    update BUILDING.md
    add missing org.slf4j:slf4j-log4j12 exclusions to Hadoop test dependencies
---
 BUILDING.md | 14 +++++++++++++-
 pom.xml     | 24 ++++++++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/BUILDING.md b/BUILDING.md
index a49e374..79423d1 100644
--- a/BUILDING.md
+++ b/BUILDING.md
@@ -67,12 +67,24 @@ $ mvn clean package -Dpackage.phoenix.client 
-Dphoenix.version=5.1.1 -Dphoenix.c
 `mvn package` will run the unit tests while building, but it will not run the 
integration test suite.
 
 The integration tests will run with the default Phoenix and HBase version.
-Running the integration tests with non-default Phoenix and HBase versions is 
not supported.
+Running the integration tests with non-default Phoenix and HBase versions may 
or may not work.
 
 ```
 $ mvn clean verify
 ```
 
+
+If a different Phoenix version is used for testing, then at least the 
*hbase.version*
+and *hadoop.version* properties must be set to the versions used to build 
phoenix-client-embdedd,
+but other changes may also be needed, or there may be un-resolvable conflicts.
+
+```
+$ mvn clean verify -Dphoenix.version=5.1.3 -Pshade-javax-servlet 
-Dphoenix.client.artifactid=phoenix-client-embedded-hbase-2.4 
-Dhadoop.version=3.1.3 -Dhbase.version=2.4.15  -DforkCount=6'
+```
+
+(At the time of writing, the above will run, but fail because 5.1.3 does not 
have PHOENIX-5066
+required by the failing test)
+
 ### Running project reports
 
 Phoenix-queryserver currently supports generating the standard set of Maven 
Project Info Reports,
diff --git a/pom.xml b/pom.xml
index b8ef38e..d167ecb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1072,6 +1072,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-reload4j</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
             <dependency>
@@ -1096,6 +1100,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-reload4j</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
             <dependency>
@@ -1120,6 +1128,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-reload4j</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
             <dependency>
@@ -1136,6 +1148,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-reload4j</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
             <dependency>
@@ -1160,6 +1176,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-log4j12</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                     <exclusion>
                         <groupId>log4j</groupId>
                         <artifactId>log4j</artifactId>
@@ -1208,6 +1228,10 @@
                         <groupId>org.slf4j</groupId>
                         <artifactId>slf4j-reload4j</artifactId>
                     </exclusion>
+                    <exclusion>
+                        <groupId>org.slf4j</groupId>
+                        <artifactId>slf4j-log4j12</artifactId>
+                    </exclusion>
                 </exclusions>
             </dependency>
             <dependency>

Reply via email to