sunithabeeram commented on a change in pull request #3856: Check assigned
instances for uploading new segment
URL: https://github.com/apache/incubator-pinot/pull/3856#discussion_r258707062
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1686,6 +1687,25 @@ private void
sendSegmentRefreshMessage(OfflineSegmentZKMetadata segmentZKMetadat
}
}
+ /**
+ * Gets assigned instances for uploading new segment. This method can be
used to detect
Review comment:
Please update the comment. The intent is not to just to discover
misconfigurations. You can remove the second sentence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
