jackjlli commented on a change in pull request #3834: Unify move method in PinotFS URL: https://github.com/apache/incubator-pinot/pull/3834#discussion_r260498035
########## File path: pinot-filesystem/src/main/java/org/apache/pinot/filesystem/PinotFS.java ########## @@ -22,14 +22,19 @@ import java.io.File; import java.io.IOException; import java.net.URI; +import java.nio.file.Paths; import org.apache.commons.configuration.Configuration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * The PinotFS is intended to be a thin wrapper on top of different filesystems. This interface is intended for internal * Pinot use only. This class will be implemented for each pluggable storage type. */ Review comment: Thanks for the detail! I'll add your comments to the API doc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
