sunithabeeram commented on a change in pull request #4037: Add more logs to
ServiceStatus
URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270607396
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##########
@@ -227,70 +230,98 @@ private boolean isDone() {
@Override
public synchronized Status getServiceStatus() {
+ String descriptionSuffix = "";
while (!isDone()) {
String resourceName;
if (_resourceIterator == null || !_resourceIterator.hasNext()) {
_resourceIterator = _resourcesToMonitor.iterator();
}
resourceName = _resourceIterator.next();
- IdealState idealState = getResourceIdealState(resourceName);
+ descriptionSuffix = String
+ .format("waitingFor=%s, resource=%s, numResourcesLeft=%d,
numTotalResources=%d, minStartCount=%d,", getMatchName(),
+ resourceName, _resourcesToMonitor.size(),
_numTotalResourcesToMonitor, _minResourcesStartCount);
- // If the resource has been removed or disabled, ignore it
- if (idealState == null || !idealState.isEnabled()) {
+ Pair<Status, String> statusPair = evaluateResourceStatus(resourceName,
descriptionSuffix);
+
+ // Resource is done starting up, remove it from the set
Review comment:
This should move below 249?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
