kishoreg commented on a change in pull request #4382: Fix java client
connection close
URL: https://github.com/apache/incubator-pinot/pull/4382#discussion_r298627703
##########
File path: pinot-api/src/main/java/org/apache/pinot/client/Connection.java
##########
@@ -156,4 +157,13 @@ public ResultSetGroup get(long timeout, TimeUnit unit)
return new ResultSetGroup(response);
}
}
+
+ /**
+ * connection close.
+ */
+ public void close() {
+ if(Objects.nonNull(_transport)) {
+ System.exit(0);
Review comment:
we should never have system.exit in the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
