codecov-io commented on issue #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#issuecomment-509544466 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=h1) Report > Merging [#4399](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/732a7b9228cb602f685909460e44a4ef76e77272?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `82.75%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4399 +/- ## =========================================== + Coverage 65.34% 65.4% +0.06% Complexity 20 20 =========================================== Files 1066 1069 +3 Lines 55415 55566 +151 Branches 7894 7910 +16 =========================================== + Hits 36209 36344 +135 - Misses 16641 16647 +6 - Partials 2565 2575 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `70.87% <ø> (-0.7%)` | `0 <0> (ø)` | | | [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.71% <ø> (+0.08%)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/core/minion/BackfillDateTimeColumn.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vQmFja2ZpbGxEYXRlVGltZUNvbHVtbi5qYXZh) | `56.25% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../java/org/apache/pinot/common/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvSnNvblV0aWxzLmphdmE=) | `43.47% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ata/recordtransformer/SanitizationTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL1Nhbml0aXphdGlvblRyYW5zZm9ybWVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...e/data/recordtransformer/CompositeTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlY29yZHRyYW5zZm9ybWVyL0NvbXBvc2l0ZVRyYW5zZm9ybWVyLmphdmE=) | `83.33% <100%> (ø)` | `0 <0> (?)` | | | [...che/pinot/core/data/readers/RecordReaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyVXRpbHMuamF2YQ==) | `78.2% <100%> (+2.89%)` | `0 <0> (ø)` | :arrow_down: | | [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvSExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `81.21% <100%> (+0.29%)` | `0 <0> (ø)` | :arrow_down: | | [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50Q29udmVydGVyLmphdmE=) | `74.62% <100%> (-0.38%)` | `0 <0> (ø)` | | | [...creator/RecordReaderSegmentCreationDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvUmVjb3JkUmVhZGVyU2VnbWVudENyZWF0aW9uRGF0YVNvdXJjZS5qYXZh) | `69.23% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [55 more](https://codecov.io/gh/apache/incubator-pinot/pull/4399/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=footer). Last update [732a7b9...4b31f3b](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
