mcvsubbu commented on a change in pull request #4323: [Controller Separation]
Add logic for lead controller resource
URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304150968
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -139,6 +139,9 @@ public ControllerStarter(ControllerConf conf) {
} else {
_adminApp =
new
ControllerAdminApiApplication(_config.getQueryConsoleWebappPath(),
_config.getQueryConsoleUseHttps());
+ // Helix instance type should explicitly be set to PARTICIPANT ONLY in
{@link ControllerStarter}.
+ // Other places like {@link PerfBenchmarkDriver} which directly call
{@link PinotHelixResourceManager} should NOT register as PARTICIPANT, which
would be put to lead controller resource and mess up the leadership assignment.
Those places should use ADMINISTRATOR other than PARTICIPANT.
+ _config.setHelixInstanceType(InstanceType.PARTICIPANT);
Review comment:
see comment above regarding the config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
