Jackie-Jiang commented on a change in pull request #4500: Add file-evening to
hadoop pre-process
URL: https://github.com/apache/incubator-pinot/pull/4500#discussion_r311792086
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
##########
@@ -412,17 +423,40 @@ private void fetchResizingConfig() {
}
}
- private void setMaxNumRecordsConfigIfSpecified(Job job) {
+ // TODO: Handle case where #records exceed long max
Review comment:
Exceed long max? We don't need to consider Long overflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
