jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r313058968
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ########## @@ -146,7 +150,8 @@ public PinotHelixResourceManager(@Nonnull String zkURL, @Nonnull String helixClusterName, @Nonnull String controllerInstanceId, String dataDir, long externalViewOnlineToOfflineTimeoutMillis, - boolean isSingleTenantCluster, boolean enableBatchMessageMode, boolean allowHLCTables) { + boolean isSingleTenantCluster, boolean enableBatchMessageMode, boolean allowHLCTables, + InstanceType helixInstanceType) { Review comment: No need to keep this instance type any more. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org