Jackie-Jiang commented on a change in pull request #4323: [Controller
Separation] Add logic for lead controller resource
URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r313700370
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -147,6 +150,9 @@ public ControllerStarter(ControllerConf conf) {
} else {
_adminApp =
new
ControllerAdminApiApplication(_config.getQueryConsoleWebappPath(),
_config.getQueryConsoleUseHttps());
+ // Helix instance type should be explicitly set to PARTICIPANT ONLY in
{@link ControllerStarter}.
Review comment:
Why putting the comments here? It should be in
PinotHelixResourceManager.start() as the comments for the argument
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
