mcvsubbu commented on a change in pull request #4536: [Instance Assignment]
Rename instance level replica to replica-group
URL: https://github.com/apache/incubator-pinot/pull/4536#discussion_r315449791
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/InstancePartitions.java
##########
@@ -33,19 +33,21 @@
/**
* Instance (server) partitions for the table.
*
- * <p>The instance partitions is stored as a map from partition of the format:
{@code <partitionId>_<replicaId>} to
+ * <p>The instance partitions is stored as a map from partition of the format:
{@code <partitionId>_<replicaGroupId>} to
* list of server instances, and is persisted under the ZK path: {@code
<cluster>/PROPERTYSTORE/INSTANCE_PARTITIONS}.
+ * <p>When partition is not enabled, all instances will be stored as partition
0.
Review comment:
Suggest : s/partition/column value based partitioning/
- Also, clarify the znode name. Is it raw table name or typed table name?
Need to clarify somewhere that this has nothing to do with stream partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
