fx19880617 commented on a change in pull request #4556: Support aws s3 with
Parquet in pinot-tools
URL: https://github.com/apache/incubator-pinot/pull/4556#discussion_r317260114
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -362,20 +357,31 @@ public boolean accept(File dir, String name) {
ExecutorService executor = Executors.newFixedThreadPool(_numThreads);
int cnt = 0;
- for (final File file : files) {
+ for (final Path dataFilePath : dataFilePaths) {
final int segCnt = cnt;
executor.execute(new Runnable() {
@Override
public void run() {
try {
SegmentGeneratorConfig config = new
SegmentGeneratorConfig(segmentGeneratorConfig);
- config.setInputFilePath(file.getAbsolutePath());
+
Review comment:
yes. I've also tested:
```
bin/pinot-admin.sh CreateSegment -dataDir /tmp/sample-pinot-data -outDir
/tmp/pinot-data -tableName sampleTable -segmentName sampleTable_0 -schemaFile
/tmp/sample_schema.json -overwrite -format parquet
``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
