mcvsubbu commented on a change in pull request #4562: Handle the virtual column
logic in FieldSpec instead of Schema
URL: https://github.com/apache/incubator-pinot/pull/4562#discussion_r317417312
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -153,6 +154,11 @@ public void setVirtualColumnProvider(String
virtualColumnProvider) {
_virtualColumnProvider = virtualColumnProvider;
}
+ @JsonIgnore
+ public boolean isVirtualColumn() {
+ return _virtualColumnProvider != null && !_virtualColumnProvider.isEmpty();
Review comment:
Are we allowing column names to start with $ for physical columns as well?
Or, are we allowing virtual column names to start with characters other than
"$"? I did not see checks for either of these (so happens that the in0built
virtual columns are starting with dollar sign). Would be good to add a comment
here about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
