siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r319207638
########## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ########## @@ -124,6 +143,14 @@ public TransformOperator run() { return new TransformOperator(_projectionPlanNode.run(), new ArrayList<>(_expressionTrees)); } + FieldSpec.DataType[] getProjectedColumnTypes() { Review comment: One reason is performance. If you look at TransformPlanNode::extractColumnsAndTransforms, this is the function that compiles each column expression in aggregation info to expression tree, and extracts the projected column names. Doing this outside again will be expensive and repeated work ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org