siddharthteotia commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r320624678
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -213,6 +231,32 @@ private static Expression convertOrderBy(SqlNode node) {
return expression;
}
+ /**
+ * DISTINCT is implemented as an aggregation function so need to take the
select list items
+ * and convert them into a single function expression for handing over to
execution engine
+ * either as a PinotQuery or BrokerRequest via conversion
+ * @param selectList select list items
+ * @return DISTINCT function expression
+ */
+ private static Expression
convertDistinctAndSelectListToFunctionExpression(final SqlNodeList selectList) {
+ final String functionName = FunctionCallAstNode.DISTINCT_FUNCTION_NAME;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
