jackjlli commented on a change in pull request #4591: Deleting preprocess 
output post segment creation
URL: https://github.com/apache/incubator-pinot/pull/4591#discussion_r323445582
 
 

 ##########
 File path: 
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
 ##########
 @@ -90,6 +91,11 @@ public SegmentCreationJob(Properties properties) {
       _pushLocations = null;
     }
 
+    String preprocessOutputPath = 
_properties.getProperty(JobConfigConstants.PREPROCESS_PATH_TO_OUTPUT);
 
 Review comment:
   I would say if user has specified `PREPROCESS_PATH_TO_OUTPUT`, it's ok to 
keep it.
   If not, use a tmp dir as the preprocess output path, then remove this tmp 
dir when the whole workflow finished.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to