gortiz commented on code in PR #14946:
URL: https://github.com/apache/pinot/pull/14946#discussion_r1935371135
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -186,11 +216,11 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
return new
BrokerResponseNative(QueryException.getException(QueryException.QUERY_VALIDATION_ERROR,
e));
} catch (WebApplicationException e) {
throw e;
- } catch (RuntimeException e) {
- String consolidatedMessage =
ExceptionUtils.consolidateExceptionMessages(e);
+ } catch (Throwable t) {
+ String consolidatedMessage =
ExceptionUtils.consolidateExceptionMessages(t);
LOGGER.warn("Caught exception planning request {}: {}, {}", requestId,
query, consolidatedMessage);
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.REQUEST_COMPILATION_EXCEPTIONS,
1);
- if (e.getMessage().matches(".* Column .* not found in any table'")) {
+ if (t.getMessage().matches(".* Column .* not found in any table'")) {
Review Comment:
just an error I've found: t.getMessage may be null. Given you are touching
this line, can you also modify this line to check if the message is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
