vincentchenjl commented on a change in pull request #4611: [TE] Remove the
logic of reading stderr from phantomjs to avoid zombie processes
URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324294233
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/alert/util/AlertScreenshotHelper.java
##########
@@ -70,25 +67,9 @@ private static String takeScreenshot(String anomalyId,
String dashboardHost, Str
LOG.info("imgPath {}", imgPath);
Process proc = Runtime.getRuntime().exec(new String[]{phantomJsPath,
"phantomjs", "--ssl-protocol=any", "--ignore-ssl-errors=true",
phantomScript, imgRoute, imgPath});
-
- StringBuilder sbError = new StringBuilder();
Review comment:
There should not be any side-effect on performance or stability. The only
problem is that we can no longer know the reason in the case of failure if we
don't stream the stderr, which was not the case before this change either
(`sbError` is never printed in previous version). If we want to know what's
going on in the child phantomjs process without having the zombie issue, we
have to use non-blocking I/O API to stream the stderr, if we think that's is
necessary for debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]