ankitsultana commented on code in PR #14981:
URL: https://github.com/apache/pinot/pull/14981#discussion_r1941907710
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -87,7 +87,13 @@ public MultistageGroupByExecutor(
_aggType = aggType;
_leafReturnFinalResult = leafReturnFinalResult;
_resultSchema = resultSchema;
+
int maxInitialResultHolderCapacity =
getMaxInitialResultHolderCapacity(opChainMetadata, nodeHint);
+ Integer mseCapacity =
getMSEMaxInitialResultHolderCapacity(opChainMetadata, nodeHint);
+ if (mseCapacity != null) {
+ maxInitialResultHolderCapacity = mseCapacity;
Review Comment:
I guess the behavior we are implementing is:
1. By default use the previous behavior
2. If a user has explicitly set a hint for the mse initial capacity, or set
a server config, then use that.
Can you also call it out in the Issue Description? We'll have to update
Pinot Docs too later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
