Jackie-Jiang commented on code in PR #15029:
URL: https://github.com/apache/pinot/pull/15029#discussion_r1951324251
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##########
@@ -250,7 +251,7 @@ public List<String> getCheckReloadSegmentsFromServer(String
tableNameWithType, S
}
LOGGER.debug("Retrieved metadata of reload check from servers.");
- return serversNeedReloadResponses;
+ return new ImmutablePair<>(serviceResponse._failedResponseCount,
serversNeedReloadResponses);
Review Comment:
Consider wrapping this into a class to improve readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
