yashmayya commented on code in PR #15024:
URL: https://github.com/apache/pinot/pull/15024#discussion_r1952055695
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java:
##########
@@ -89,12 +89,26 @@ private PlanNode process(PlanNode node, Context context) {
@Override
public void onSubstitution(int receiver, int oldSender, int newSender) {
+ // Change the sender of the receiver to the new sender
IntList senders = _childPlanFragmentIdsMap.get(receiver);
senders.rem(oldSender);
if (!senders.contains(newSender)) {
senders.add(newSender);
}
+
+ // Remove the old sender and its children from the plan fragment map
Review Comment:
This can be removed now since it'll be done in the first iteration of the
loop right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
