Jackie-Jiang commented on code in PR #15048:
URL: https://github.com/apache/pinot/pull/15048#discussion_r1955191185
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -282,6 +287,42 @@ protected void removeSegmentFromStore(String
tableNameWithType, String segmentId
}
}
+ /**
+ * Gets URI for segment deletion by attempting to locate the segment file in
the following order:
+ * 1. Plain segment file (without extension)
+ * 2. Compressed segment file (with .tar.gz extension)
Review Comment:
Both of them are compressed segment file, but different way of upload could
result in different format. Let's document some details. I think only the
minion task could result in segment file with extension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
