bziobrowski commented on code in PR #15095:
URL: https://github.com/apache/pinot/pull/15095#discussion_r1963059050
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -184,14 +185,16 @@ public void processBlock(TransferableBlock block) {
}
/**
- * Get aggregation result limited to first {@code maxRows} rows, ordered
with {@code sortedRows} collection.
+ * Get aggregation result limited to first {@code maxRows} rows, ordered
with {@code comparator}.
*/
- public List<Object[]> getResult(PriorityQueue<Object[]> sortedRows, int
maxRows) {
+ public List<Object[]> getResult(Comparator<Object[]> comparator, int
maxRows) {
int numGroups = Math.min(_groupIdGenerator.getNumGroups(), maxRows);
if (numGroups == 0) {
return Collections.emptyList();
}
Review Comment:
Isn't it already ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
