Jackie-Jiang commented on code in PR #15088:
URL: https://github.com/apache/pinot/pull/15088#discussion_r1972308667
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -146,6 +147,7 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
protected HelixExternalViewBasedQueryQuotaManager _queryQuotaManager;
protected MultiStageQueryThrottler _multiStageQueryThrottler;
protected AbstractResponseStore _responseStore;
+ protected BrokerGrpcServer _brokerGrpcServer;
Review Comment:
TLS port is not enabled by default, and requires explicit configuration. My
concern is that certain users might not want to assign a separate port for
gRPC, but rather not opening it. I'd suggest checking the configured port, and
only start the gRPC server when the port is positive (same as how TLS port is
used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
