vrajat commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1977272204
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -76,11 +76,12 @@ default void toOutputStream(OutputStream outputStream)
/**
* Returns the processing exceptions encountered during the query execution.
*/
- List<QueryProcessingException> getExceptions();
+ // TODO: Rename this method
+ List<BrokerResponseErrorMessage> getExceptions();
Review Comment:
This change will cause backward incompatibility for clients. If you search
for `QueryProcessingException` in:
* `org:startreedata` - there are multiple places where it is used in
startree-pinot. It will help if you have a PR ready to remove references as it
is not trivial for others to fix the compilation issue
* All of github - It is used trinodb.
https://github.com/trinodb/trino/pull/14399/files
I suggest you deprecate and keep this function as is. Anyway you plan to
rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
