klsince commented on code in PR #15178:
URL: https://github.com/apache/pinot/pull/15178#discussion_r1983808352
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/DedupIntegrationTest.java:
##########
@@ -59,8 +72,41 @@ public void setUp()
addSchema(schema);
TableConfig tableConfig = createDedupTableConfig(_avroFiles.get(0), "id",
getNumKafkaPartitions());
addTableConfig(tableConfig);
-
waitForAllDocsLoaded(600_000L);
+ createDedupConfigsWithReplicas();
+ }
+
+ public void createDedupConfigsWithReplicas()
+ throws IOException {
+ Schema schemaWithReplicas = createSchema(getSchemaFileName());
+ schemaWithReplicas.setSchemaName(DEDUP_WITH_REPLICAS_SCHEMA);
+ addSchema(schemaWithReplicas);
+ TableConfig tableConfigWithReplication =
+ createDedupTableConfigWithReplication(_avroFiles.get(0), "id",
getNumKafkaPartitions());
+ addTableConfig(tableConfigWithReplication);
+ waitForDocsLoaded(600_000L, true, DEDUP_TABLE_WITH_REPLICAS);
+ }
+
+ /**
+ * Creates a new Dedup enabled table config with replication=2 and
metadatTTL=30
+ */
+ protected TableConfig createDedupTableConfigWithReplication(File
sampleAvroFile, String primaryKeyColumn,
Review Comment:
nit: ...WithReplicas to be consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
