somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1984345215
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##########
@@ -55,40 +55,64 @@ public InstanceAssignmentDriver(TableConfig tableConfig) {
public InstancePartitions assignInstances(InstancePartitionsType
instancePartitionsType,
List<InstanceConfig> instanceConfigs, @Nullable InstancePartitions
existingInstancePartitions) {
+ return assignInstances(instancePartitionsType, instanceConfigs,
existingInstancePartitions, false);
+ }
+
+ public InstancePartitions assignInstances(InstancePartitionsType
instancePartitionsType,
+ List<InstanceConfig> instanceConfigs, @Nullable InstancePartitions
existingInstancePartitions,
+ boolean forceMinimizeDataMovement) {
Review Comment:
oh, now I understand what your suggestion is @Jackie-Jiang, I think I
misunderstood before. I think your suggestion makes sense, especially the use
case to try out and see the difference between `true` and `false`. I know I've
wanted to do this while testing to see when it even matters and when it doesn't
apply. @J-HowHuang let's model this flag as: `true`, `false`, `use table
config` - you'll need to figure out how to model this in
`PinotTableRestletResource`
(btw good catch on missing `PinotTableRestletResource`, somehow I completely
missed this in the review - @J-HowHuang please add the flag there otherwise it
won't show up in swagger - please test this out in swagger locally on your
machine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
