icefury71 commented on issue #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-532923579 > Sorry for the delay. I was out for a while for the conference. > > Would you add the following to the commit message? > > 1. Link #4230 for the reference. After I read the issue, this pr made much more sense. > 2. Add the description on how presence vector is populated. By reading the code, it seems that we generate presence vector by default. > 3. Can you also add a little bit more explanation to the commit message on when you filter out NULL values? (e.g. when predicate is added by user -- column != NULL...) > > I think that most comments are minor & style issues. I will do one more final review after this. Thanks for pointing that out. Updated description. Please take a look
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
