itschrispeck commented on code in PR #15139:
URL: https://github.com/apache/pinot/pull/15139#discussion_r1987864905
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -594,4 +594,17 @@ public void close()
}
}
}
+
+ /**
+ * Close the DataFetcher and release all resources (specifically, the
ForwardIndexReaderContext off-heap buffers).
+ */
+ public void close() {
+ try {
+ for (ColumnValueReader columnValueReader :
_columnValueReaderMap.values()) {
+ columnValueReader.close();
+ }
+ } catch (IOException e) {
+ // do nothing
Review Comment:
I think it becomes a backwards incompat change if we rethrow it - changing
it to close the context on a jvm that does not support the same cleaner methods
would be breaking
Another approach might be to use `CleanerUtil.closeQuietly(..)` within each
context's close() impl, and then just use AutoClosable instead of Closable for
the ColumnValueReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
