9aman commented on code in PR #15241:
URL: https://github.com/apache/pinot/pull/15241#discussion_r1990706147
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionConfig.java:
##########
@@ -44,8 +48,10 @@ public SegmentCompletionConfig(PinotConfiguration
configuration) {
}
}
- // Get the default FSM scheme
+ // Get the default FSM and pauseless FSM scheme
_defaultFsmScheme = configuration.getProperty(DEFAULT_FSM_SCHEME_KEY,
DEFAULT_FSM_SCHEME);
+ _defaultPauselessFsmScheme =
Review Comment:
I do not see any explosion in the number of FSM's going forward. Also, this
keeps the createFSM part of the code more readable. That's why chose to add
this.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionFSMFactory.java:
##########
@@ -34,9 +34,10 @@ private SegmentCompletionFSMFactory() {
private static final Logger LOGGER =
LoggerFactory.getLogger(SegmentCompletionFSMFactory.class);
private static final Map<String, Class<? extends SegmentCompletionFSM>>
FSM_CLASS_MAP = new HashMap<>();
- // Static block to register the default FSM
+ // Static block to register the default FSM and pauseless FSM
static {
register(SegmentCompletionConfig.DEFAULT_FSM_SCHEME,
BlockingSegmentCompletionFSM.class);
+ register(SegmentCompletionConfig.DEFAULT_PAUSELESS_FSM_SCHEME,
PauselessSegmentCompletionFSM.class);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
