noob-se7en commented on code in PR #15246:
URL: https://github.com/apache/pinot/pull/15246#discussion_r1991396562
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1684,8 +1695,6 @@ public RealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableConf
_segmentLogger
.info("Starting consumption on realtime consuming segment {}
maxRowCount {} maxEndTime {}", llcSegmentName,
_segmentMaxRowCount, new DateTime(_consumeEndTime,
DateTimeZone.UTC));
- _allowConsumptionDuringCommit =
!_realtimeTableDataManager.isPartialUpsertEnabled() ? true
- :
_tableConfig.getUpsertConfig().isAllowPartialUpsertConsumptionDuringCommit();
Review Comment:
why is this not checking for dedup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
