noob-se7en commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r1993424037
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1063,12 +1063,7 @@ AtomicBoolean getAcquiredConsumerSemaphore() {
@VisibleForTesting
protected SegmentBuildDescriptor buildSegmentInternal(boolean forCommit) {
- // for partial upsert tables, do not release
_partitionGroupConsumerSemaphore proactively and rely on offload()
- // to release the semaphore. This ensures new consuming segment is not
consuming until the segment replacement is
- // complete.
- if (_allowConsumptionDuringCommit) {
- closeStreamConsumers();
Review Comment:
Need to confirm side effect of removing this. Since A new consumer can
start consuming and updating the dedup metadata and immutable segment of
currently building segment also accesses the metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
