lnbest0707-uber commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r1999706050
##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java:
##########
@@ -1022,7 +1027,13 @@ protected void postStopConsumedMsg(String reason) {
_postConsumeStoppedCalled = true;
}
- // TODO: Some of the tests rely on specific number of calls to the `now()`
method in the SegmentDataManager.
+ @Override
+ protected void notifySegmentCannotBuild() {
+ _notifySegmentCannotBuildCalled = true;
+ }
+
+
+ // TODO: Some of the tests rely on specific number of calls to the
`now()` method in the SegmentDataManager.
Review Comment:
good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
