9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r2000870263
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -190,7 +190,11 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
REINGESTED_SEGMENT_UPLOADS_IN_PROGRESS("reingestedSegmentUploadsInProgress",
true),
// Resource utilization is within limits or not for a table
- RESOURCE_UTILIZATION_LIMIT_EXCEEDED("ResourceUtilizationLimitExceeded",
false);
+ RESOURCE_UTILIZATION_LIMIT_EXCEEDED("ResourceUtilizationLimitExceeded",
false),
Review Comment:
The ControllerGauge has a mixed of formats used for naming.
Won't it introduce backwards compatibility issue as this will change the
metric name in prometheus/ grafana ?
Also, I haven't added this metric and is not part of the PR. I am happy to
change it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
