lnbest0707-uber commented on code in PR #15234:
URL: https://github.com/apache/pinot/pull/15234#discussion_r2002285709
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1093,6 +1093,35 @@ public void segmentStoppedConsuming(LLCSegmentName
llcSegmentName, String instan
}
}
+ /**
+ * An instance is reporting that it cannot build segment due to
non-recoverable error, usually due to size too large.
Review Comment:
When one segment build failed and the other has not committed (either
succeed or fail), controller would reduce the size and **reset the segment**.
This would force to destroy the mutable segment and reingest.
When one segment build failed but the other has already succeed and commit,
controller will drop the request and allow the succeed one completes its build.
The failed one will eventually be replaced by the one built by the succeed one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
