gortiz commented on code in PR #15277:
URL: https://github.com/apache/pinot/pull/15277#discussion_r2005726502
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -531,4 +619,20 @@ public FailureDetector.ServerState
retryUnhealthyServer(String instanceId) {
return _queryDispatcher.checkConnectivityToInstance(serverInstance);
}
+
+ public static boolean isYellowError(QueryException e) {
+ switch (e.getErrorCode()) {
+ case QUERY_SCHEDULING_TIMEOUT:
+ case EXECUTION_TIMEOUT:
+ case INTERNAL:
+ case UNKNOWN:
Review Comment:
Red errors are errors we didn't catch and somehow bubbled up to the
`handleRequest`. By definition, QueryExceptions are never red exceptions. Even
if they are internal or unknown, we already caught them and explicitly set a
user error message for them.
Colors are not about how problematic the error is. Instead, they are focused
on how we want to log the error and how/what send to used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
