gortiz commented on code in PR #15264:
URL: https://github.com/apache/pinot/pull/15264#discussion_r2007193302
##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -88,9 +87,12 @@ public void log(QueryLogParams params) {
queryLogBuilder.append(',');
}
- // always log the query last - don't add this to the QueryLogEntry enum
+ // update: stop logging the query itself here, as it will already be
logged in the request handler
+ /*
queryLogBuilder.append("query=")
.append(StringUtils.substring(params._requestContext.getQuery(), 0,
_maxQueryLengthToLog));
+ */
+ queryLogBuilder.setLength(queryLogBuilder.length() - 1);
Review Comment:
I think there may be users using this log already. I think it is better to
log the query twice than breaking compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
