J-HowHuang commented on code in PR #15284:
URL: https://github.com/apache/pinot/pull/15284#discussion_r2011028375
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -699,6 +714,26 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
serverSegmentChangeInfoMap.put(server, new
RebalanceSummaryResult.ServerSegmentChangeInfo(serverStatus,
totalNewSegments, totalExistingSegments, segmentsAdded,
segmentsDeleted, segmentsUnchanged,
instanceToTagsMap.getOrDefault(server, null)));
+ List<String> serverTags = getServerTag(server);
+ // Since this is a server in the target assignment, it should contain at
least one tag of the tenant or tier
+ // server tag. Note that if the server is tagged with multiple tenant or
tier tags that are used in the table
+ // config, we will count it multiple times, i.e. the total segment count
would not add up to the actual total.
+ if (serverTags.isEmpty()) {
+ LOGGER.warn(
Review Comment:
Yeah agree. The problem could also occur when tags are removed but the
rebalance had `reassignInstance=false`
What about categorize all the traffics into these servers without relevant
tags (including no tags) to `"tenantName": "UNCATEGORIZED_TENANT"` (could have
better name)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
