somandal commented on code in PR #15360:
URL: https://github.com/apache/pinot/pull/15360#discussion_r2012528795
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -97,7 +98,8 @@ public Map<String, RebalancePreCheckerResult>
check(PreCheckContext preCheckCont
* TODO: Add an API to check for whether segments in deep store are up to
date with the table configs and schema
* and add a pre-check here to call that API.
*/
- private RebalancePreCheckerResult checkReloadNeededOnServers(String
rebalanceJobId, String tableNameWithType) {
+ private RebalancePreCheckerResult checkReloadNeededOnServers(String
rebalanceJobId, String tableNameWithType,
Review Comment:
Also, EV eventually converges with IS, so even if they are different
temporarily, it is expected to get to the same IS state. So if a server exists
in EV, but not in IS, it means that the segments from that server are getting
deleted anyways, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
