Jackie-Jiang commented on code in PR #15330:
URL: https://github.com/apache/pinot/pull/15330#discussion_r2012896634


##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -48,6 +48,21 @@ rules:
     table: "$2$4"
     tableType: "$5"
     taskType: "$6"
+  # Special handling for timers like cronSchedulerJobExecutionTimeMs and 
tableRebalanceExecutionTimeMs

Review Comment:
   Can we combine these 2 into the special rule for 
`cronSchedulerJobScheduled`? Seems they are all the same pattern



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to