somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013092611
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
if (segmentsAdded > 0) {
serversGettingNewSegments.add(server);
}
+ if (!isOfflineTable) {
+ if (bytesToCatchUpForServers != null) {
+ bytesToCatchUpForServers.put(server, 0);
+ }
Review Comment:
why would it be weird? we only care about servers getting new consuming
segments, right? if deleted, we don't care. If it doesn't move, we don't care.
let me know if I'm missing something here though
If majority of the servers are not getting new consuming segments, it'll be
a lot of 0's right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
