somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2013184415
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -693,6 +738,21 @@ private RebalanceSummaryResult
calculateDryRunSummary(Map<String, Map<String, St
if (segmentsAdded > 0) {
serversGettingNewSegments.add(server);
}
+ if (!isOfflineTable) {
+ if (bytesToCatchUpForServers != null) {
+ bytesToCatchUpForServers.put(server, 0);
+ }
+ for (String segment : newSegmentSet) {
+ if (consumingSegments.contains(segment)) {
+ consumingSegmentsToBeMoved++;
+ if (bytesToCatchUpForSegments != null) {
Review Comment:
Agreed about failed requests - just need one for each partition
as a user, if I want to know information about CONSUMING segments in the
summary, and I just see nothing, now I'll have to go look at logs to debug and
find out why? will I always need to do this? what if I'm not paying attention
but would have if I had some information indicating error? Just returning null
for error case can be problematic as we don't always expect to get this filled
in (e.g. offline tables, or realtime tables without consuming included), right?
My main concern is that how do I know whether I should look into warning
logs or not based on the summary output? that's why I think just capturing in
the summary that some error was seen would be helpful so that the caller knows
that they should debug or re-run. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
