noob-se7en commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2014065172
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -172,6 +172,14 @@ public boolean isFinal() {
}
}
+ @VisibleForTesting
+ enum ParallelSegmentConsumptionPolicy {
Review Comment:
There is already confusing configs like:
_tableConfig.getUpsertConfig().isAllowPartialUpsertConsumptionDuringCommit()
&& _tableConfig.getDedupConfig().isAllowDedupConsumptionDuringCommit()
Shall we introduce another one? And which one then will take precedence? I
think we should deprecate above configs and just expose
ParallelSegmentConsumptionPolicy as a config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
