somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2019854016
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##########
@@ -34,10 +34,7 @@
@JsonIgnoreProperties(ignoreUnknown = true)
@JsonInclude(JsonInclude.Include.NON_NULL)
public class RebalanceSummaryResult {
-
- @JsonInclude(JsonInclude.Include.NON_NULL)
private final ServerInfo _serverInfo;
- @JsonInclude(JsonInclude.Include.NON_NULL)
private final SegmentInfo _segmentInfo;
@JsonInclude(JsonInclude.Include.NON_NULL)
Review Comment:
any reason to keep this NON_NULL annotation when it exists for the class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
