somandal commented on code in PR #15392:
URL: https://github.com/apache/pinot/pull/15392#discussion_r2021416028
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -53,6 +53,19 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
NETTY_POOLED_ARENAS_HEAP("arenas", true),
STREAM_DATA_LOSS("streamDataLoss", false),
+ // Segment operation throttle metrics - threshold is the upper limit of the
throttle and is set whenever the
+ // throttle configs are modified
+
SEGMENT_TABLE_DOWNLOAD_THROTTLE_THRESHOLD("segmentTableDownloadThrottleThreshold",
false),
+ SEGMENT_DOWNLOAD_THROTTLE_THRESHOLD("segmentDownloadThrottleThreshold",
true),
+
SEGMENT_ALL_PREPROCESS_THROTTLE_THRESHOLD("segmentAllPreprocessThrottleThreshold",
true),
+
SEGMENT_STARTREE_PREPROCESS_THROTTLE_THRESHOLD("segmentStartreePreprocessDownloadThreshold",
true),
Review Comment:
oops, good catch. done
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentStarTreePreprocessThrottler.java:
##########
@@ -41,7 +42,8 @@ public class SegmentStarTreePreprocessThrottler extends
BaseSegmentOperationsThr
public SegmentStarTreePreprocessThrottler(int
maxStarTreePreprocessConcurrency,
int maxStarTreePreprocessConcurrencyBeforeServingQueries, boolean
isServingQueries) {
super(maxStarTreePreprocessConcurrency,
maxStarTreePreprocessConcurrencyBeforeServingQueries, isServingQueries,
- LOGGER);
+ ServerGauge.SEGMENT_STARTREE_PREPROCESS_THROTTLE_THRESHOLD,
+ ServerGauge.SEGMENT_STARTREE_PREPROCESS_COUNT, LOGGER);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
