Jackie-Jiang commented on code in PR #15281:
URL: https://github.com/apache/pinot/pull/15281#discussion_r2025660642
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -84,7 +84,7 @@ public static Map<String, String>
resolveCaseInsensitiveOptions(Map<String, Stri
Map<String, String> resolved = new HashMap<>();
for (Map.Entry<String, String> configEntry : queryOptions.entrySet()) {
- String config = CONFIG_RESOLVER.get(configEntry.getKey().toLowerCase());
+ String config = resolveCaseInsensitiveKey(configEntry.getKey());
Review Comment:
We can revert this since we already know the key is `String`
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -95,6 +95,14 @@ public static Map<String, String>
resolveCaseInsensitiveOptions(Map<String, Stri
return resolved;
}
+ @Nullable
+ public static String resolveCaseInsensitiveKey(Object property) {
+ if (property instanceof String) {
+ return QueryOptionsUtils.CONFIG_RESOLVER.get(((String)
property).toLowerCase());
Review Comment:
(nit)
```suggestion
return CONFIG_RESOLVER.get(((String) property).toLowerCase());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
