gviedma commented on code in PR #15437:
URL: https://github.com/apache/pinot/pull/15437#discussion_r2027857512
##########
pom.xml:
##########
@@ -271,6 +271,24 @@
<ivy.version>2.5.3</ivy.version>
<c3p0.version>0.11.0-pre2</c3p0.version>
<mchange-commons-java.version>0.3.2</mchange-commons-java.version>
+ <checker-qual.version>3.49.2</checker-qual.version>
Review Comment:
I did some investigation and found that some of the google cloud libraries
(e.g.
[proto-google-iam](https://repo1.maven.org/maven2/com/google/api/grpc/proto-google-iam-v1/1.49.1/proto-google-iam-v1-1.49.1.pom))
are setting an explicit version for
com.google.api.grpc:proto-google-common-protos, so that the version defined in
the io.grpc bom ends up getting overridden. To work around that and make the
version of this package overridable when building Pinot, you will need to do:
1. Define a version property and set it to 2.54.1 (that’s the current
version resolved by Maven)
2. Define a dependency for it in dependencyManagement, but make sure to put
it before the entry for com.google.cloud:libraries-bom or it won’t take effect
(suggest placing it right before with a comment that it needs to appear before
it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
